Saulparedes/fix always allowed #316
Draft
+2,539
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redent0r
commented
Feb 21, 2025
| .allow_env_regex_map | ||
| .contains_key(&self.name) | ||
| { | ||
| panic!( |
There was a problem hiding this comment.
Since we are removing the rule that "allows for anything", panic, since the policy we would produce otherwise won't be allowed anyways
Redent0r
commented
Feb 21, 2025
| @@ -785,11 +785,15 @@ allow_var(p_process, i_process, i_var, s_name, s_namespace) { | |||
|
|
|||
| p_name_value[0] == name_value[0] | |||
|
|
|||
| # TODO: should these be handled in a different way? | |||
| always_allowed = ["$(resource-field)", "$(todo-annotation)"] | |||
There was a problem hiding this comment.
if we go with this route, we no longer need resource-field, todo-annotation distinction. These could all be $(validate-from-settings)
Redent0r
commented
Feb 21, 2025
| ] | ||
| ], | ||
| "allow_env_regex_map": { | ||
| "JOB_COMPLETION_INDEX": "^[0-9]+$" |
There was a problem hiding this comment.
temporarily added for testing. Need to think about how to test our samples without checking in exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
upstream/missinglabel (orupstream/not-needed) has been set on the PR.Summary
Test Methodology